Prevent JSON parse error #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users can pass in `{ enabled: true }` as the sortOptions, which means `initialSortBy` would be `undefined` and `JSON.parse` throws an error when you hand it `undefined`. So we need to default the value if it is not present.
TheJaredWilcurt
commented
Mar 9, 2021
| @@ -1582,7 +1582,7 @@ export default { | |||
|
|
|||
| initializeSort() { | |||
| const { enabled, initialSortBy, multipleColumns } = this.sortOptions; | |||
| const initSortBy = JSON.parse(JSON.stringify(initialSortBy)); | |||
| const initSortBy = JSON.parse(JSON.stringify(initialSortBy || {})); | |||
There was a problem hiding this comment.
If initialSortBy is undefined default to an empty object to prevent JSON.parse(undefined) error from throwing.
|
@xaksis Updating to the latest version and most of my tests broke with super cryptic error messages. Took a while to track this down, but it was a very easy fix. |
|
I came to dig into this same issue. Thanks for fixing it. |
|
Thanks @TheJaredWilcurt ! |
This was referenced Mar 12, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can pass in
{ enabled: true }as the sortOptions, which meansinitialSortBywould beundefinedandJSON.parsethrows an error when you hand itundefined. So we need to default the value if it is not present.