-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Android] Fix issue with Shape not resizing correctly (rotate screen) #14702
Conversation
I was hoping to try this change, but the build went boom, so no package to test :( |
@MitchBomcanhao Now the build is passing, could you try the package? |
@jsuarezruiz thanks, I've been looking into it this morning. I've added more information on bug #14697 - essentially:
You can find more detail and screenshots in the bug page. |
@jsuarezruiz @MitchBomcanhao if I understand correctly this PR still needs some work? |
@jsuarezruiz @jfversluis well, the first change you've done is already very positive 👍(shame it didn't make the cut to SR6), but the path should also rescale itself when the path data value is changed. Thanks |
So, merging this would help you, but the 100% fix needs some additional work. Does it make sense to merge this as is, open a new issue with the remainder and see if we can get to that? Then at least you have some progress here. |
yes, that would be ok. would you want me to log the new bug entry? |
FYI created bug #14765 |
Great, thanks! |
Description of Change
Fix issue with Shape not resizing correctly (rotate screen).
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Launch Core Gallery and navigate to the issue 14697. Rotate the Device or Emulator If the Shape size adapts (Aspect = Uniform), the test has passed.
PR Checklist