Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: fix: bad /data replacement #76

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cyrinux
Copy link
Contributor

@cyrinux cyrinux commented Apr 24, 2024

I tooks few minutes to realize the replace was not well done and eat some path 😄

There is maybe still another edge case, i make some tries.

@cyrinux cyrinux changed the title fix: bad /data replace Draft: fix: bad /data replace Apr 24, 2024
@cyrinux cyrinux marked this pull request as draft April 24, 2024 09:44
@cyrinux cyrinux changed the title Draft: fix: bad /data replace Draft: fix: bad /data replacement Apr 24, 2024
@xbglowx
Copy link
Owner

xbglowx commented May 17, 2024

Thanks for working on this. Should it still be a draft PR?

@cyrinux
Copy link
Contributor Author

cyrinux commented May 17, 2024 via email

@xbglowx
Copy link
Owner

xbglowx commented May 17, 2024

Yes, for sure there is still issue around this but I don't have the time to dig more for the moment. Feel free to do it if you can/want. May 17, 2024 14:58:04 Brian Glogower @.***>:

Thanks for working on this. Should it still be a draft PR? — Reply to this email directly, view it on GitHub[#76 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAD6XKZNSIVKIQN5RRAGDFTZCX5FRAVCNFSM6AAAAABGWRXHLKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJXGU2DMOBSGU]. You are receiving this because you authored the thread. [Tracking image][https://github.com/notifications/beacon/AAD6XK3QZ753YARKWNOI2P3ZCX5FRA5CNFSM6AAAAABGWRXHLKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTT6G4ZUS.gif]

Can you please give some test data/examples that will help reproduce?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants