Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure session not to trust env #48

Merged
merged 1 commit into from
Sep 28, 2018
Merged

Configure session not to trust env #48

merged 1 commit into from
Sep 28, 2018

Conversation

jeffakolb
Copy link
Collaborator 

don't pick up .netrc dummy creds

@jeffakolb
Configure session not to trust env
42add5b 
    don't pick up .netrc dummy creds
@CLAassistant
Copy link

CLAassistant commented Sep 28, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jeffakolb
Copy link
Collaborator Author

This PR addresses issue #43 in a more straightforward way that PR #44. At least part of the problem is that requests looks for credentials in a .netrc file if authentication isn't specified in the session or the request. Many machines have a default un/pw in their .netrc. Ignoring the env stops this behavior and prevents the Oauth2 authentication header from being over-written.

@binaryaaron binaryaaron self-assigned this Sep 28, 2018
@binaryaaron
Copy link
Contributor

@jeffakolb - make sure to release this version to Pypi when you get a chance; thanks!

@binaryaaron binaryaaron merged commit 49d8900 into master Sep 28, 2018
@binaryaaron binaryaaron deleted the premium_auth_bugfix branch September 28, 2018 21:39
jeffakolb added a commit that referenced this pull request Oct 1, 2018
@jeffakolb
Update _version.py
c951af8 
Bump version for #48
jeffakolb added a commit that referenced this pull request Oct 8, 2018
@jeffakolb
Configure session not to trust env (#48)
93fb22c 
don't pick up .netrc dummy creds
jeffakolb added a commit that referenced this pull request Oct 8, 2018
@jeffakolb
Configure session not to trust env (#48)
20450c6 
don't pick up .netrc dummy creds
binaryaaron pushed a commit that referenced this pull request Oct 16, 2018
@jeffakolb
Header options (#49)
c145396 
* Configure session not to trust env (#48)

don't pick up .netrc dummy creds

* Handle extra headers from config file or cmd-line

* Set correct order in dict merge

    Command line should overwrite config/creds files

* Update docs for custom header option

* Update _version.py

bump version

* Fix naming for extra headers option
@bunnyhero bunnyhero mentioned this pull request Jan 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@binaryaaron binaryaaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffakolb @CLAassistant @binaryaaron