-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression with games now showing distance based (mip mapping?) issues #1002
Comments
Note: Forza is only for reference as it doesn't officially work in master yet |
A similar issue also began presenting in Splinter Cell, coinciding with 0.7.17 and 0.7.18 in the same way. These artifacts now show with the rain seen in some levels: |
@7oxicshadow can you add the compatibility links for the titles so they're properly linked? https://xemu.app/titles/4d53006e/#Forza-Motorsport Not sure if Blazing Aces is the same as Blazing Angels, and not sure if Outrun is Outrun 2 |
Azurik Rise of Perathia |
Not sure what your asking? I shared the games that toxic mentioned. But have no other request open. |
Presumably that was meant for @7oxicshadow since the links need to be added to the bug description in this issue so they get associated in the compatibility page. |
Original post updated |
I expanded the pgraph test suite to check mipmaps xemu departs from hardware when the mipmap image has an axis drop below 4 (e.g., 2x8 in both my 64_256_bands_dxt1.dds test and in a Forza renderdoc grab) |
`GL_UNPACK_ROW_LENGTH` is supposed to set the length in pixels, but the DXT path is setting it to bytes, causing it to read beyond the end of the texture. [Reference](https://www.khronos.org/registry/OpenGL-Refpages/gl4/html/glPixelStore.xhtml) Fixes xemu-project#1002 [Test](https://github.com/abaire/nxdk_pgraph_tests/blob/main/src/tests/texture_format_dxt_tests.cpp) [HW Results](https://github.com/abaire/nxdk_pgraph_tests_golden_results/wiki/Results-Texture_DXT)
`GL_UNPACK_ROW_LENGTH` is supposed to set the length in pixels, but the DXT path is setting it to bytes, causing it to read beyond the end of the texture. [Reference](https://www.khronos.org/registry/OpenGL-Refpages/gl4/html/glPixelStore.xhtml) Fixes #1002 [Test](https://github.com/abaire/nxdk_pgraph_tests/blob/main/src/tests/texture_format_dxt_tests.cpp) [HW Results](https://github.com/abaire/nxdk_pgraph_tests_golden_results/wiki/Results-Texture_DXT)
`GL_UNPACK_ROW_LENGTH` is supposed to set the length in pixels, but the DXT path is setting it to bytes, causing it to read beyond the end of the texture. [Reference](https://www.khronos.org/registry/OpenGL-Refpages/gl4/html/glPixelStore.xhtml) Fixes xemu-project#1002 [Test](https://github.com/abaire/nxdk_pgraph_tests/blob/main/src/tests/texture_format_dxt_tests.cpp) [HW Results](https://github.com/abaire/nxdk_pgraph_tests_golden_results/wiki/Results-Texture_DXT)
Bug Description
The following games have started exhibiting possible distance based graphics corruption (mip mapping?).
Outrun / Forza / Crimson Skies / Blazing Aces
Steps to reproduce:
theboy181 did a search to find the problem version in master and confirmed that 7.17 is fine and 7.18 is broken.
7.18 is a change that incorporated pull request 962 ( #962 )
We have confirmed that if you revert this pull request it seems to resolve the issue.
Links:
https://xemu.app/titles/55530057/#Blazing-Angels-Squadrons-of-WWII
https://xemu.app/titles/53450036/#OutRun-2
https://xemu.app/titles/53450088/#OutRun-2006-Coast-2-Coast
https://xemu.app/titles/4d53006e/#Forza-Motorsport
https://xemu.app/titles/4d530021/#Crimson-Skies-High-Road-to-Revenge
https://xemu.app/titles/41430007/#Aggressive-Inline
Expected Behavior
No graphics corruption
xemu Version
Works in release 7.17
Broken in 7.18
System Information
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: