Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression with games now showing distance based (mip mapping?) issues #1002

Closed
7oxicshadow opened this issue May 31, 2022 · 14 comments · Fixed by #1148
Closed

Regression with games now showing distance based (mip mapping?) issues #1002

7oxicshadow opened this issue May 31, 2022 · 14 comments · Fixed by #1148
Labels
bug Something isn't working

Comments

@7oxicshadow
Copy link
Contributor

7oxicshadow commented May 31, 2022

Bug Description

The following games have started exhibiting possible distance based graphics corruption (mip mapping?).

Outrun / Forza / Crimson Skies / Blazing Aces

Steps to reproduce:

  1. Launch one of the games above
  2. Go in game
  3. Observe the following issues

forza
image
image

theboy181 did a search to find the problem version in master and confirmed that 7.17 is fine and 7.18 is broken.

7.18 is a change that incorporated pull request 962 ( #962 )

We have confirmed that if you revert this pull request it seems to resolve the issue.

Links:
https://xemu.app/titles/55530057/#Blazing-Angels-Squadrons-of-WWII
https://xemu.app/titles/53450036/#OutRun-2
https://xemu.app/titles/53450088/#OutRun-2006-Coast-2-Coast
https://xemu.app/titles/4d53006e/#Forza-Motorsport
https://xemu.app/titles/4d530021/#Crimson-Skies-High-Road-to-Revenge
https://xemu.app/titles/41430007/#Aggressive-Inline

Expected Behavior

No graphics corruption

xemu Version

Works in release 7.17
Broken in 7.18

System Information

No response

Additional Context

No response

@7oxicshadow 7oxicshadow added the bug Something isn't working label May 31, 2022
@7oxicshadow
Copy link
Contributor Author

Note: Forza is only for reference as it doesn't officially work in master yet

@cazzhmir
Copy link

A similar issue also began presenting in Splinter Cell, coinciding with 0.7.17 and 0.7.18 in the same way. These artifacts now show with the rain seen in some levels:

0.7.17:
https://user-images.githubusercontent.com/104662859/171293730-119d8236-7f9a-4de2-a9f5-1215642e24dc.mp4

0.7.18:
https://user-images.githubusercontent.com/104662859/171293750-450e78a3-b93d-4b4e-bb82-71d5324fd61a.mp4

@abaire
Copy link
Contributor

abaire commented Jun 1, 2022

@7oxicshadow can you add the compatibility links for the titles so they're properly linked?

https://xemu.app/titles/4d53006e/#Forza-Motorsport
https://xemu.app/titles/4d530021/#Crimson-Skies-High-Road-to-Revenge

Not sure if Blazing Aces is the same as Blazing Angels, and not sure if Outrun is Outrun 2

@Triticum0
Copy link

Triticum0 commented Jun 5, 2022

Azurik Rise of Perathia
Gotcha!

@theboy181
Copy link
Contributor

@theboy181 please add the links of the games mentioned here to your original request, so the issues will appear on their respective pages and it will be easier to see them.

Not sure what your asking? I shared the games that toxic mentioned. But have no other request open.

@abaire
Copy link
Contributor

abaire commented Jun 5, 2022

@theboy181 please add the links of the games mentioned here to your original request, so the issues will appear on their respective pages and it will be easier to see them.

Not sure what your asking? I shared the games that toxic mentioned. But have no other request open.

Presumably that was meant for @7oxicshadow since the links need to be added to the bug description in this issue so they get associated in the compatibility page.

@7oxicshadow
Copy link
Contributor Author

Original post updated

@abaire
Copy link
Contributor

abaire commented Jul 1, 2022

I expanded the pgraph test suite to check mipmaps

Test
HW results

xemu departs from hardware when the mipmap image has an axis drop below 4 (e.g., 2x8 in both my 64_256_bands_dxt1.dds test and in a Forza renderdoc grab)

abaire added a commit to abaire/xemu that referenced this issue Jul 1, 2022
mborgerson pushed a commit that referenced this issue Jul 1, 2022
ChrisNonyminus pushed a commit to redscientistlabs/xemu-Vanguard that referenced this issue Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@abaire @theboy181 @7oxicshadow @Triticum0 @cazzhmir and others