Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: input onChange handler #1040

Merged
merged 1 commit into from
Feb 8, 2023
Merged

fix: input onChange handler #1040

merged 1 commit into from
Feb 8, 2023

Conversation

StereoPT
Copy link
Contributor

@StereoPT StereoPT commented Feb 7, 2023

Relates to #1035
Fixes #1035

Proposed Changes

  • Added a onChange handler to the Email / Password Inputs to set the Form Value.
  • The problem was that the react-form-hooks only sets the input value onBlur.

This pull request closes #1035

@StereoPT StereoPT added bug Something isn't working frontend labels Feb 7, 2023
@StereoPT StereoPT requested a review from a team February 7, 2023 15:27
@StereoPT StereoPT linked an issue Feb 7, 2023 that may be closed by this pull request
[BUG] Pressing enter on login screen password field #1035
Closed
@StereoPT StereoPT self-assigned this Feb 7, 2023
@StereoPT StereoPT merged commit 25ee6e8 into main Feb 8, 2023
@StereoPT StereoPT deleted the 1035-bug-pressing-enter-on-login-screen-password-field branch February 8, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees

@StereoPT StereoPT

Labels
bug Something isn't working frontend
Projects
SPLIT • Bugs
Status: Done
SPLIT • Frontend
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Pressing enter on login screen password field
2 participants
@StereoPT @nunocaseiro