Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add slack channel id to a team #1078

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

mourabraz
Copy link
Contributor

Fixes #1073

Proposed Changes

  • keep the size of teams unchanged, even if a channel was not created in SlackCommunicationApplication@createAllChannels

@nunocaseiro

Note: I still not using the factory to create fake data.

This pull request closes #1073

@mourabraz mourabraz added bug Something isn't working backend labels Feb 14, 2023
@mourabraz mourabraz added this to the Full Version milestone Feb 14, 2023
@mourabraz mourabraz self-assigned this Feb 14, 2023
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nunocaseiro nunocaseiro merged commit 08f5e61 into main Feb 15, 2023
@nunocaseiro nunocaseiro deleted the fix--add-slack-channel-id-to-a-team branch February 15, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG]: keep the team even without a slack channel id
2 participants