Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: regular board public private #1093

Merged
merged 12 commits into from
Feb 17, 2023
Merged

feat: regular board public private #1093

merged 12 commits into from
Feb 17, 2023

Conversation

patricia-mdias
Copy link
Contributor

@patricia-mdias patricia-mdias commented Feb 16, 2023 •
edited
Loading

Relates to #742

Proposed Changes

  • Create guest User and Board User endpoint, given a board.
  • Create only Board User endpoint, given an user and board.
  • Get public board endpoint.
  • Get public status endpoint, to check if board is public.

@patricia-mdias patricia-mdias added enhancement New feature or request backend labels Feb 16, 2023
@patricia-mdias patricia-mdias added this to the Full Version milestone Feb 16, 2023
@patricia-mdias patricia-mdias requested a review from a team February 16, 2023 11:55
@patricia-mdias patricia-mdias self-assigned this Feb 16, 2023
@patricia-mdias patricia-mdias marked this pull request as draft February 16, 2023 17:47
@patricia-mdias patricia-mdias marked this pull request as ready for review February 16, 2023 18:29
nunocaseiro
nunocaseiro previously approved these changes Feb 16, 2023
View reviewed changes
backend/src/modules/auth/controller/auth.controller.ts Outdated Show resolved Hide resolved
@patricia-mdias patricia-mdias marked this pull request as draft February 17, 2023 11:00
@patricia-mdias patricia-mdias marked this pull request as ready for review February 17, 2023 12:59
nunocaseiro
nunocaseiro approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 GJ 🔥

@patricia-mdias patricia-mdias merged commit ae90167 into main Feb 17, 2023
@patricia-mdias patricia-mdias deleted the feat/regular-board-publicprivate branch February 17, 2023 14:17
GoncaloCanteiro pushed a commit that referenced this pull request Feb 22, 2023
@patricia-mdias @CatiaAntunes96 @GoncaloCanteiro
feat: regular board public private (#1093)
5168513 
Co-authored-by: Cátia Antunes <c.antunes@kigroup.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees

@CatiaAntunes96 CatiaAntunes96

@patricia-mdias patricia-mdias

Labels
backend enhancement New feature or request
Projects
SPLIT • Backend
Status: Done
Milestone
Full Version
Development

Successfully merging this pull request may close these issues.
3 participants
@patricia-mdias @nunocaseiro @CatiaAntunes96