Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: alert box primitive story #1113

Merged
merged 3 commits into from
Feb 17, 2023
Merged

feat: alert box primitive story #1113

merged 3 commits into from
Feb 17, 2023

Conversation

jpvsalvador
Copy link
Contributor

Relates to #1112
Fixes #1112

Proposed Changes

  • Add a gap between board columns so the alert box is aligned on the left side. How it was before:

image

Now:

image

  • Add the AlertBox primitive to Storybook

This pull request closes #1112

@jpvsalvador jpvsalvador added documentation Improvements or additions to documentation frontend labels Feb 17, 2023
@jpvsalvador jpvsalvador requested a review from a team February 17, 2023 16:33
@jpvsalvador jpvsalvador self-assigned this Feb 17, 2023
@jpvsalvador jpvsalvador linked an issue Feb 17, 2023 that may be closed by this pull request
[FEATURE]: alert box primitive story #1112
Closed
@jpvsalvador jpvsalvador merged commit 8c678b1 into main Feb 17, 2023
@jpvsalvador jpvsalvador deleted the 1112-feature-alert-box-primitive-story branch February 17, 2023 16:53
GoncaloCanteiro pushed a commit that referenced this pull request Feb 22, 2023
@jpvsalvador @GoncaloCanteiro
feat: alert box primitive story (#1113)
f3dcb2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees

@jpvsalvador jpvsalvador

Labels
documentation Improvements or additions to documentation frontend
Projects
SPLIT • Frontend
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: alert box primitive story
2 participants
@jpvsalvador @nunocaseiro