Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: check user exists methods #113

Merged
merged 2 commits into from
Mar 22, 2022
Merged

refactor: check user exists methods #113

merged 2 commits into from
Mar 22, 2022

Conversation

nunocaseiro
Copy link
Contributor

@nunocaseiro nunocaseiro commented Mar 21, 2022 •
edited
Loading

Relates to #112

Proposed Changes

  • Refactor "check user exist" method to check if the user is present in the AD and/or on the database
  • Check user exist method and endpoint to check if the user exists only on the database
  • This two methods are built in order to use one or the other if the azure module is enabled or not

This pull request is intented to close #112

@nunocaseiro nunocaseiro requested a review from a team March 21, 2022 12:26
@nunocaseiro nunocaseiro force-pushed the refactor-validate-email branch 5 times, most recently from 7a32704 to b17a755 Compare March 21, 2022 16:04
rpvsilva
rpvsilva requested changes Mar 21, 2022
View reviewed changes
backend/src/libs/test-utils/mocks/user.mock.ts Outdated Show resolved Hide resolved
backend/src/modules/auth/controller/auth.controller.ts Outdated Show resolved Hide resolved
backend/src/modules/auth/controller/auth.controller.ts Outdated Show resolved Hide resolved
backend/src/modules/auth/controller/auth.controller.ts Show resolved Hide resolved
backend/src/modules/auth/shared/login.auth.ts Outdated Show resolved Hide resolved
backend/src/modules/azure/controller/azure.controller.ts Outdated Show resolved Hide resolved
rpvsilva
rpvsilva approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@rpvsilva rpvsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@nunocaseiro nunocaseiro merged commit 924fe6b into xgeekshq:main Mar 22, 2022
@nunocaseiro nunocaseiro deleted the refactor-validate-email branch November 18, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpvsilva rpvsilva rpvsilva approved these changes

Assignees
No one assigned
Labels
authentication backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: check user exists
2 participants
@nunocaseiro @rpvsilva