Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send xgeeks board phase to slack #1156

Merged
merged 52 commits into from
Feb 28, 2023
Merged

Conversation

GoncaloCanteiro
Copy link
Contributor

Relates to #1048

Screenshots (if visual changes)

image
image

Proposed Changes

  • Add new service to communication in order to receive SlackChannelId and the message to send
  • Call the service when phase updated

This pull request closes #1048

Button to start voting phase sends webSocket to the backend.
Backend sends webSocket to frontend.
when phase is updated sends websocket to boardId
change updateBoardPhase to accept phase of the board.
Remove socketId from AlertVotePhase
change fetch to boardService
Button show when all sub-boards merged and phase in "addcards"
Frontend changes
 -updateBoardPhaseRequest changed the way it sends the body
 -On board.ts changed the id name be the same as the endpoint dto

Backend changes
 -add BoardPhaseDto to the endpoint
@GoncaloCanteiro GoncaloCanteiro self-assigned this Feb 27, 2023
@GoncaloCanteiro GoncaloCanteiro added backend enhancement New feature or request labels Feb 27, 2023
@GoncaloCanteiro GoncaloCanteiro added this to the Full Version milestone Feb 27, 2023
@GoncaloCanteiro GoncaloCanteiro requested a review from a team February 27, 2023 14:44
@GoncaloCanteiro GoncaloCanteiro marked this pull request as ready for review February 27, 2023 14:45
nunocaseiro
nunocaseiro previously approved these changes Feb 28, 2023
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@GoncaloCanteiro GoncaloCanteiro merged commit 3d16fb8 into main Feb 28, 2023
@GoncaloCanteiro GoncaloCanteiro deleted the feat/update-phase-slack branch February 28, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Add the voting phase
2 participants