Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generic factory #1200

Merged
merged 1 commit into from
Mar 8, 2023
Merged

feat: generic factory #1200

merged 1 commit into from
Mar 8, 2023

Conversation

nunocaseiro
Copy link
Contributor

Relates to #1199

Proposed Changes

  • Add generic factory
  • Update tests

This pull request closes #1199

@nunocaseiro nunocaseiro added this to the Full Version milestone Mar 7, 2023
@nunocaseiro nunocaseiro self-assigned this Mar 7, 2023
@nunocaseiro nunocaseiro requested review from CatiaAntunes96 and a team March 7, 2023 12:22
CatiaAntunes96
CatiaAntunes96 approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@CatiaAntunes96 CatiaAntunes96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nunocaseiro nunocaseiro merged commit 7f65276 into main Mar 8, 2023
@nunocaseiro nunocaseiro deleted the feat/generic-factory branch March 8, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CatiaAntunes96 CatiaAntunes96 CatiaAntunes96 approved these changes

Assignees

@nunocaseiro nunocaseiro

Labels
backend
Projects
SPLIT • Backend
Status: Done
Milestone
Full Version
Development

Successfully merging this pull request may close these issues.

[FEATURE]: generic factory
2 participants
@nunocaseiro @CatiaAntunes96