Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: communication consumers tests #1249

Merged
merged 19 commits into from
Mar 16, 2023
Merged

test: communication consumers tests #1249

merged 19 commits into from
Mar 16, 2023

Conversation

GoncaloCanteiro
Copy link
Contributor

Relates to:

Fixes:

  • Removed saveLog from slack-communication-event-listeners
  • Add tests to all consumers

This pull request closes:

@GoncaloCanteiro
test: add slack-responsible.consumer test
29069f1
@GoncaloCanteiro
refactor: message from slack-send-message it
8dfec49
@GoncaloCanteiro
refactor: fix typo in file name
35f6f6a
@GoncaloCanteiro
fix: change import path
dae2268
@GoncaloCanteiro
fix: missing parentheses in createMock
2a59a79
@GoncaloCanteiro
test: add slack-add-user-channel.consumer test
553d452
@GoncaloCanteiro
fix: remove saveLog
6aa68e0 
This method is not relevant anymore
@GoncaloCanteiro
fix: changed names
4247124
@GoncaloCanteiro
refactor: change tests descriptions
f87c5c5
@GoncaloCanteiro
test: add slack-archive-channel.consumer test
079d7fb
@GoncaloCanteiro
fix: change expect to toHaveBeenNthCalledWith
de920ae
@GoncaloCanteiro
test: add slack-merge-board.consumer test
509400f
@GoncaloCanteiro
test: add Logger spys in slack-archive
11a7e88
@GoncaloCanteiro
fix: applicationMocks names
a825b7e
@GoncaloCanteiro
test: add slack-communication-consumer
b761864
@GoncaloCanteiro
fix: remove saveLog from communication listener
1999a67
@GoncaloCanteiro
test: add slack-communication.consumer test
dd1b557
@GoncaloCanteiro
test: add slack-communication-event-listeners test
9a44f49
@GoncaloCanteiro
fix: change slack-communication boardType name
687e760
@GoncaloCanteiro GoncaloCanteiro added this to the Full Version milestone Mar 15, 2023
@GoncaloCanteiro GoncaloCanteiro self-assigned this Mar 15, 2023
@GoncaloCanteiro GoncaloCanteiro linked an issue Mar 15, 2023 that may be closed by this pull request
[TEST]: communication consumers #1238
Closed
@GoncaloCanteiro GoncaloCanteiro marked this pull request as ready for review March 15, 2023 18:08
nunocaseiro
nunocaseiro approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@GoncaloCanteiro GoncaloCanteiro merged commit 2cce1e3 into main Mar 16, 2023
@GoncaloCanteiro GoncaloCanteiro deleted the test/communication-consumers branch March 16, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees

@GoncaloCanteiro GoncaloCanteiro

Labels
backend tests
Projects
SPLIT • Backend
Status: Done
Milestone
Full Version
Development

Successfully merging this pull request may close these issues.

[TEST]: communication consumers
2 participants
@GoncaloCanteiro @nunocaseiro