Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: communication applications tests #1258

Merged
merged 11 commits into from
Mar 20, 2023
Merged

test: communication applications tests #1258

merged 11 commits into from
Mar 20, 2023

Conversation

GoncaloCanteiro
Copy link
Contributor

Relates to:

Proposed Changes

-Add tests to communication applications

This pull request closes:

@GoncaloCanteiro GoncaloCanteiro added this to the Full Version milestone Mar 16, 2023
@GoncaloCanteiro GoncaloCanteiro self-assigned this Mar 16, 2023
@GoncaloCanteiro GoncaloCanteiro linked an issue Mar 16, 2023 that may be closed by this pull request
[TEST]: communication applications tests #1255
Closed
@GoncaloCanteiro GoncaloCanteiro changed the title Test/communication applications tests Ttest: communication applications tests Mar 16, 2023
@GoncaloCanteiro GoncaloCanteiro changed the title Ttest: communication applications tests test: communication applications tests Mar 16, 2023
@GoncaloCanteiro GoncaloCanteiro marked this pull request as ready for review March 16, 2023 17:52
nunocaseiro
nunocaseiro requested changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ here! You just missed some lines. If you think there is a line that doesn't make sense to test or the tests don't return value please leave a comment with your opinion
image

backend/src/modules/communication/applications/slack-add-user-channel.application.ts Outdated Show resolved Hide resolved
backend/src/modules/communication/applications/slack-add-user-channel.application.ts Outdated Show resolved Hide resolved
nunocaseiro
nunocaseiro previously approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 🚀

@GoncaloCanteiro GoncaloCanteiro marked this pull request as draft March 17, 2023 17:56
@GoncaloCanteiro GoncaloCanteiro marked this pull request as ready for review March 20, 2023 12:27
nunocaseiro
nunocaseiro approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@GoncaloCanteiro GoncaloCanteiro merged commit 3b3ff06 into main Mar 20, 2023
@GoncaloCanteiro GoncaloCanteiro deleted the test/communication-applications-tests branch March 20, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourabraz mourabraz mourabraz left review comments

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees

@GoncaloCanteiro GoncaloCanteiro

Labels
backend tests
Projects
SPLIT • Backend
Status: Done
Milestone
Full Version
Development

Successfully merging this pull request may close these issues.

[TEST]: communication applications tests
3 participants
@GoncaloCanteiro @mourabraz @nunocaseiro