Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update board service #1259

Merged
merged 16 commits into from
Mar 20, 2023
Merged

test: update board service #1259

merged 16 commits into from
Mar 20, 2023

Conversation

CatiaAntunes96
Copy link
Contributor

Relates to:

Proposed Changes

  • Refactor of the functions on update board service
  • Add tests to functions of update board service

This pull request closes:

@CatiaAntunes96 CatiaAntunes96 added this to the Full Version milestone Mar 17, 2023
@CatiaAntunes96 CatiaAntunes96 self-assigned this Mar 17, 2023
@CatiaAntunes96 CatiaAntunes96 requested review from nunocaseiro and a team March 17, 2023 09:59
nunocaseiro
nunocaseiro requested changes Mar 19, 2023
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have missed some lines. We should also create a test for the merge boards

backend/src/modules/boards/services/update.board.service.spec.ts Show resolved Hide resolved
backend/src/modules/boards/services/update.board.service.spec.ts Outdated Show resolved Hide resolved
backend/src/modules/boards/services/update.board.service.spec.ts Outdated Show resolved Hide resolved
backend/src/modules/boards/services/update.board.service.spec.ts Show resolved Hide resolved
backend/src/modules/boards/services/update.board.service.spec.ts Outdated Show resolved Hide resolved
backend/src/modules/boards/services/update.board.service.ts Outdated Show resolved Hide resolved
backend/src/modules/boards/services/update.board.service.ts Outdated Show resolved Hide resolved
backend/src/modules/boards/services/update.board.service.ts Outdated Show resolved Hide resolved
backend/src/modules/boards/services/update.board.service.ts Outdated Show resolved Hide resolved
backend/src/modules/boards/services/update.board.service.ts Outdated Show resolved Hide resolved
nunocaseiro
nunocaseiro requested changes Mar 19, 2023
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have some missed tests for these lines:

Screenshot 2023-03-19 at 18 54 25

nunocaseiro
nunocaseiro previously approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@CatiaAntunes96 CatiaAntunes96 merged commit 4118fff into main Mar 20, 2023
@CatiaAntunes96 CatiaAntunes96 deleted the test/update-board-service branch March 20, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees

@CatiaAntunes96 CatiaAntunes96

Labels
backend tests
Projects
SPLIT • Backend
Status: Done
Milestone
Full Version
Development

Successfully merging this pull request may close these issues.
2 participants
@CatiaAntunes96 @nunocaseiro