refactor: team user module #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunocaseiro
requested changes
Mar 19, 2023
There was a problem hiding this comment.
You should create a new controller for the teamUser that handles all the related endpoints. So the methods that are in the team controller that are related with the teamUser should be moved to the new controller teamUser.controller.ts. You can use the same path as the team controller if you want
The folder's name for this new module should be teamUser. Same for the boardUsers -> boardUser.
backend/src/modules/teamusers/applications/add-and-remove-team-users.use-case.ts
Outdated
Show resolved
Hide resolved
backend/src/modules/teamusers/applications/add-and-remove-team-users.use-case.ts
Outdated
Show resolved
Hide resolved
backend/src/modules/teamusers/applications/create-team-user.use-case.ts
Outdated
Show resolved
Hide resolved
backend/src/modules/teamusers/applications/create-team-users.use-case.ts
Outdated
Show resolved
Hide resolved
backend/src/modules/teamusers/applications/delete-team-user.use-case.ts
Outdated
Show resolved
Hide resolved
backend/src/modules/teamusers/applications/update-team-user.use-case.ts
Outdated
Show resolved
Hide resolved
|
with this branch when I create a team it doesn't appear on the team's page |
nunocaseiro
requested changes
Mar 21, 2023
backend/src/modules/teamUsers/interfaces/applications/team-user.use-case.interface.ts
Outdated
Show resolved
Hide resolved
backend/src/modules/teamUsers/applications/add-and-remove-team-users.use-case.ts
Outdated
Show resolved
Hide resolved
backend/src/modules/teamUsers/applications/create-team-user.use-case.ts
Outdated
Show resolved
Hide resolved
backend/src/modules/teamUsers/applications/create-team-users.use-case.ts
Outdated
Show resolved
Hide resolved
backend/src/modules/teamUsers/applications/add-and-remove-team-users.use-case.ts
Outdated
Show resolved
Hide resolved
backend/src/modules/teamUsers/applications/create-team-user.use-case.ts
Outdated
Show resolved
Hide resolved
backend/src/modules/teamUsers/applications/create-team-users.use-case.ts
Outdated
Show resolved
Hide resolved
backend/src/modules/teamUsers/applications/delete-team-user.use-case.ts
Outdated
Show resolved
Hide resolved
backend/src/modules/teamUsers/applications/update-team-user.use-case.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
Proposed Changes
This pull request closes: