Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: communication services #1274

Merged
merged 8 commits into from
Mar 21, 2023
Merged

Conversation

GoncaloCanteiro
Copy link
Contributor

Relates to:

Proposed Changes

-Add tests to all services
-Add BoardType factory and userRoleTypeFactory (used multiple times in the communication module)

This pull request closes #1269

@GoncaloCanteiro GoncaloCanteiro added this to the Full Version milestone Mar 20, 2023
@GoncaloCanteiro GoncaloCanteiro self-assigned this Mar 20, 2023
@GoncaloCanteiro GoncaloCanteiro linked an issue Mar 20, 2023 that may be closed by this pull request
@GoncaloCanteiro GoncaloCanteiro marked this pull request as ready for review March 20, 2023 16:43
@GoncaloCanteiro GoncaloCanteiro marked this pull request as draft March 20, 2023 17:14
@GoncaloCanteiro GoncaloCanteiro marked this pull request as ready for review March 20, 2023 17:15
@GoncaloCanteiro GoncaloCanteiro marked this pull request as draft March 20, 2023 17:16
@GoncaloCanteiro GoncaloCanteiro marked this pull request as ready for review March 20, 2023 17:29
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@GoncaloCanteiro GoncaloCanteiro merged commit 11413ad into main Mar 21, 2023
@GoncaloCanteiro GoncaloCanteiro deleted the test/communication-services branch March 21, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[TEST]: communication services
2 participants