Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unnecessary teams recoil state #1327

Merged
merged 6 commits into from
Mar 31, 2023
Merged

refactor: remove unnecessary teams recoil state #1327

merged 6 commits into from
Mar 31, 2023

Conversation

jpvsalvador
Copy link
Contributor

@jpvsalvador jpvsalvador commented Mar 31, 2023 •
edited
Loading

Relates to:

Fixes:

Screenshots (if visual changes)

Proposed Changes

  • Remove the unnecessary teams recoil state that could be switched to react query instead.
  • This affects the state that is mainly being used just to read data from and not being manipulated.
  • Instead of having 2 places with the same data to read from, it's better to just have the data in the cache and read it using react query.

This pull request closes #1326 and #1264

@jpvsalvador jpvsalvador linked an issue Mar 31, 2023 that may be closed by this pull request
[REFACTOR]: remove unnecessary teams recoil state #1326
Closed
@jpvsalvador jpvsalvador changed the title refactlrremove unnecessary teams recoil state refactor: remove unnecessary teams recoil state Mar 31, 2023
@jpvsalvador jpvsalvador requested a review from a team March 31, 2023 08:00
@jpvsalvador jpvsalvador self-assigned this Mar 31, 2023
@jpvsalvador jpvsalvador added enhancement New feature or request frontend labels Mar 31, 2023
@jpvsalvador jpvsalvador marked this pull request as draft March 31, 2023 09:37
@jpvsalvador jpvsalvador marked this pull request as ready for review March 31, 2023 09:47
StereoPT
StereoPT approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@StereoPT StereoPT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🗝️

@jpvsalvador jpvsalvador merged commit 53c3c7a into main Mar 31, 2023
@jpvsalvador jpvsalvador deleted the 1326-refactor-remove-unnecessary-teams-recoil-state branch March 31, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StereoPT StereoPT StereoPT approved these changes

Assignees

@jpvsalvador jpvsalvador

Labels
enhancement New feature or request frontend
Projects
SPLIT • Frontend
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR]: remove unnecessary teams recoil state
2 participants
@jpvsalvador @StereoPT