Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: active sidebar item #1389

Merged
merged 1 commit into from
Apr 13, 2023
Merged

fix: active sidebar item #1389

merged 1 commit into from
Apr 13, 2023

Conversation

StereoPT
Copy link
Contributor

Relates to:

Fixes:

Screenshots

image

Proposed Changes

  • Changed the equality path comparison to an includes.
  • This will also work on pages where the route has dynamic paths.

This pull request closes #1363

@StereoPT StereoPT added bug Something isn't working frontend labels Apr 13, 2023
@StereoPT StereoPT self-assigned this Apr 13, 2023
@StereoPT StereoPT linked an issue Apr 13, 2023 that may be closed by this pull request
[BUG]: Sidebar Current Active Page #1363
Closed
@StereoPT StereoPT merged commit ef0fbaf into main Apr 13, 2023
@StereoPT StereoPT deleted the 1363-bug-sidebar-current-active-page branch April 13, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpvsalvador jpvsalvador jpvsalvador approved these changes

Assignees

@StereoPT StereoPT

Labels
bug Something isn't working frontend
Projects
SPLIT • Bugs
Status: Done
SPLIT • Frontend
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Sidebar Current Active Page
2 participants
@StereoPT @jpvsalvador