Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: round maxUsers to 2 decimal places #1463

Merged
merged 5 commits into from
May 3, 2023
Merged

fix: round maxUsers to 2 decimal places #1463

merged 5 commits into from
May 3, 2023

Conversation

CatiaAntunes96
Copy link
Contributor

Fixes:

Proposed Changes

  • Store maxUsers with two decimal places instead of rounding the number (frontend)
  • Only round the result when calculating the number of sub-teams with Math.round (backend)

This pull request closes #1462

@CatiaAntunes96 CatiaAntunes96 added bug Something isn't working frontend backend labels May 3, 2023
@CatiaAntunes96 CatiaAntunes96 added this to the Full Version milestone May 3, 2023
@CatiaAntunes96 CatiaAntunes96 self-assigned this May 3, 2023
@CatiaAntunes96 CatiaAntunes96 merged commit 54229f0 into main May 3, 2023
@CatiaAntunes96 CatiaAntunes96 deleted the bug/cron-job-adds-sub-team branch May 3, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees

@CatiaAntunes96 CatiaAntunes96

Labels
backend bug Something isn't working frontend
Projects
SPLIT • Bugs
Status: Done
Milestone
Full Version
Development

Successfully merging this pull request may close these issues.

[BUG]: Cron Job adds sub-team
2 participants
@CatiaAntunes96 @nunocaseiro