Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: userIcon and eye-slash sprite #187

Merged
merged 3 commits into from
May 19, 2022
Merged

fix: userIcon and eye-slash sprite #187

merged 3 commits into from
May 19, 2022

Conversation

f-morgado
Copy link
Contributor

Screenshots (if visual changes)

image

image

Proposed Changes

  • userIcon used as a Sprite symbol
  • eye/eye-slash now displays when password is visible/hidden accordingly

f-morgado and others added 2 commits May 19, 2022 16:39
@f-morgado
fix: package lock
a47c9eb
@f-morgado
Delete userIcon.svg
63a8e08 
userIcon already contemplated on Sprite, no need for a .svg file
nunocaseiro
nunocaseiro approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@f-morgado f-morgado merged commit 180a70f into main May 19, 2022
@nunocaseiro nunocaseiro deleted the feat-user-icon-sprite branch June 3, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@f-morgado @nunocaseiro