Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Save stakeholders into team_user table #321

Merged
merged 29 commits into from
Jul 19, 2022
Merged

Conversation

geomarb
Copy link
Contributor

@geomarb geomarb commented Jul 11, 2022

Relates to #279

Proposed Changes

  • Keep stakeholders on database teamusers.role === 'stakeholder'

  • Move the route GET /boards/stakeholders/all to GET /teams/:teamId?userTeamRole=stakeholders

    • Remove route GET /boards/stakeholders/all

    • Create route GET /teams/:teamId which accepts loadUsers and userTeamRole query parameters to load and/or filter team users by role

  • backend and frontend ready to treat stakeholder from database

backend changes

frontend changes

contributors

Mention people who discussed this issue previously
@dsousa12 @nunocaseiro @gfdias

This pull request closes #279

@dsousa12 dsousa12 changed the title 279 stakeholders [FEATURE]: Save stakeholders into team_user table Jul 12, 2022
@dsousa12 dsousa12 requested a review from a team July 12, 2022 07:26
@dsousa12 dsousa12 added enhancement New feature or request backend labels Jul 12, 2022
@dsousa12
Copy link
Contributor

dsousa12 commented Jul 12, 2022

@geomarb LGTM 🚀, wait for others reviews

@xgeekshq xgeekshq deleted a comment from allcontributors bot Jul 12, 2022
@dsousa12
Copy link
Contributor

@all-contributors please add @geomarb as contributor for code and docs

@allcontributors
Copy link
Contributor

@dsousa12

I've put up a pull request to add @geomarb! 🎉

nunocaseiro
nunocaseiro previously approved these changes Jul 17, 2022
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@dsousa12 dsousa12 requested a review from a team July 19, 2022 07:09
dvpfran
dvpfran previously approved these changes Jul 19, 2022
@geomarb geomarb dismissed stale reviews from dvpfran and nunocaseiro via 66ed910 July 19, 2022 10:07
Copy link
Contributor

@dsousa12 dsousa12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@geomarb geomarb merged commit 18c13cb into main Jul 19, 2022
@geomarb geomarb deleted the 279-stakeholders branch July 19, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Save stakeholders into team_user table
4 participants