-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE]: Save stakeholders into team_user table #321
Conversation
…llow REST pattern
…olders to get.team.service
@geomarb LGTM 🚀, wait for others reviews |
@all-contributors please add @geomarb as contributor for code and docs |
I've put up a pull request to add @geomarb! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Relates to #279
Proposed Changes
Keep stakeholders on database
teamusers.role === 'stakeholder'
Move the route
GET /boards/stakeholders/all
toGET /teams/:teamId?userTeamRole=stakeholders
Remove route
GET /boards/stakeholders/all
Create route
GET /teams/:teamId
which acceptsloadUsers
anduserTeamRole
query parameters to load and/or filter team users by rolebackend
andfrontend
ready to treatstakeholder
from databasebackend/src/
dto/
param/
enum/
stakeholder
rolelibs/
utils/
ignored_users.json: remove filemodules/
boards/
controller/
routeGET boards/stakeholders/all
services/
stakeholder
ref fromteamUser.role
teams/
applications/
getTeam(teamId, teamQueryParams)
controller/
and addGET teams/member
GET teams/:teamId?loadUsers&userTeamRole=[member,stakeholder,admin]
with optional query params:loadUsers
to load all team users anduserTeamRole
to load and filter team users by their role in the team in the resultinterfaces/
applications/
getTeam(teamId, teamQueryParams)
to the interfaceservices/
getTeam(teamId, teamQueryParams)
to the interfaceschemas/
stakeholder
roleservices/
getTeam()
to treatteamQueryParams
accordinglyfrontend/src/
api/
which fetch data fromgetStakeholders()
GET /boards/stakeholders/all
route that was removed from backendcomponents/
Board/
Header/
stakeholder
instead of using string now it compares with the enumBoardUserRoles.STAKEHOLDER
CardBoard/
BoardUserRoles
andTeamUserRoles
CreateBoard/
SubTeamsTab/
MainBoardCard.tsx: change to get
stakeholder
fromteamUser.role
QuickEditSubTeams.tsx: remove
stakeholder
referencesTeamSubTeamsConfigurations.tsx: change to get
stakeholder
fromteamUser.role
and try to improve code readability and stop passingstakeholder
asprops
to QuickEditSubTeams and MainBoardCardhooks/
function param and compare it fromstakeholder
teamUsers.role
insteadpages/
boards/
andgetStakeholder
queryClient.prefetchQuery('stakeholders',...)
.all-contributorsrc: add Geomar as contributor
README.md: add Geomar as contributor
Mention people who discussed this issue previously
@dsousa12 @nunocaseiro @gfdias
This pull request closes #279