Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: disable button between orders #438

Merged
merged 2 commits into from
Sep 12, 2022
Merged

[BUG]: disable button between orders #438

merged 2 commits into from
Sep 12, 2022

Conversation

f-morgado
Copy link
Contributor

Fixes #436

Proposed Changes

  • disable the upvote/downvote button while the request wasnt fullfilled.
  • Prevents non stopping spam while vote request wasnt updated.

Mention people who discussed this issue previously
@CatiaBarroco-xgeeks

This pull request closes #436

@f-morgado f-morgado added this to the MVP milestone Sep 12, 2022
@f-morgado f-morgado requested a review from a team September 12, 2022 09:31
@f-morgado f-morgado self-assigned this Sep 12, 2022
@f-morgado f-morgado linked an issue Sep 12, 2022 that may be closed by this pull request
[BUG]: disable button between orders #436
Closed
joaosantos99
joaosantos99 approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@joaosantos99 joaosantos99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@CatiaBarroco-xgeeks CatiaBarroco-xgeeks merged commit 42e80b7 into main Sep 12, 2022
@CatiaBarroco-xgeeks CatiaBarroco-xgeeks deleted the fix/disable-button-between-orders branch September 12, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaosantos99 joaosantos99 joaosantos99 approved these changes

Assignees

@f-morgado f-morgado

@CatiaBarroco-xgeeks CatiaBarroco-xgeeks

Labels
frontend
Projects
SPLIT • MVP
Status: Done
Milestone
MVP
Development

Successfully merging this pull request may close these issues.

[BUG]: disable button between orders
3 participants
@f-morgado @joaosantos99 @CatiaBarroco-xgeeks