Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(socket): prevent multiple connections and update next auth #468

Merged
merged 1 commit into from
Sep 27, 2022
Merged

refactor(socket): prevent multiple connections and update next auth #468

merged 1 commit into from
Sep 27, 2022

Conversation

nunocaseiro
Copy link
Contributor

@nunocaseiro nunocaseiro commented Sep 27, 2022 •
edited
Loading

Fixes #466
Fixes #467

Proposed Changes

  • Change socketIO hook in order to avoid a user from having multiple socket connections on the same board
  • Update next-auth package

This pull request closes #466 and #467

@nunocaseiro nunocaseiro requested a review from a team September 27, 2022 15:20
@nunocaseiro nunocaseiro changed the title refactor(socket): avoid multiple connections and update next auth refactor(socket): prevent multiple connections and update next auth Sep 27, 2022
CatiaBarroco-xgeeks
CatiaBarroco-xgeeks approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@CatiaBarroco-xgeeks CatiaBarroco-xgeeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nunocaseiro nunocaseiro merged commit f442cf3 into main Sep 27, 2022
@nunocaseiro nunocaseiro deleted the fix/socket-multiple-connections branch September 27, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CatiaBarroco-xgeeks CatiaBarroco-xgeeks CatiaBarroco-xgeeks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] Update Next version [BUG] Socket disconnect/connect too often
2 participants
@nunocaseiro @CatiaBarroco-xgeeks