Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: share, edit title and delete board from the dashboard #65

Merged
merged 15 commits into from
Jan 7, 2022
Merged

feat: share, edit title and delete board from the dashboard #65

merged 15 commits into from
Jan 7, 2022

Conversation

nunocaseiro
Copy link
Contributor

@nunocaseiro nunocaseiro commented Dec 20, 2021 •
edited
Loading

Relates to #64

Screenshots

image
image
Captura de ecrã 2021-12-20, às 12 02 10

Proposed Changes

  • Implementation of a feature that allows the user to copy the board url to clipboard from the dashboard
  • Implementation of a feature that allows the user to rename the board from the dashboard
  • Implementation of a feature that allows the user to delete a board the dasboard
  • Use toastify to inform the user whether or not his actions were successful

The visual proposed changes are possible to see in the screenshots above.

This pull request is intendend to close #64

@nunocaseiro nunocaseiro self-assigned this Dec 20, 2021
@nunocaseiro nunocaseiro marked this pull request as ready for review December 20, 2021 12:18
@nunocaseiro nunocaseiro requested a review from a team December 20, 2021 12:18
jomifepe
jomifepe requested changes Jan 3, 2022
View reviewed changes
Copy link
Member

@jomifepe jomifepe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple things that could be changed, but great job on this 💪

frontend/api/boardService.tsx Outdated Show resolved Hide resolved
frontend/components/Dashboard/BoardList/CardBody.tsx Outdated Show resolved Hide resolved
frontend/components/Dashboard/BoardList/CardHeader.tsx Outdated Show resolved Hide resolved
frontend/components/Dashboard/CreateBoardModal.tsx Outdated Show resolved Hide resolved
@nunocaseiro nunocaseiro force-pushed the feature-dashboard-card-buttons branch from 530e442 to 17aca17 Compare January 6, 2022 18:55
jomifepe
jomifepe previously approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@jomifepe jomifepe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some final suggestions and you can merge away 🚀

frontend/components/Dashboard/CreateBoardModal.tsx Outdated Show resolved Hide resolved
frontend/components/Dashboard/CreateBoardModal.tsx Outdated Show resolved Hide resolved
frontend/components/Dashboard/BoardList/CardBody.tsx Outdated Show resolved Hide resolved
frontend/components/Layout/Layout.tsx Outdated Show resolved Hide resolved
@nunocaseiro nunocaseiro force-pushed the feature-dashboard-card-buttons branch from 17aca17 to df6bb3b Compare January 6, 2022 23:27
@nunocaseiro nunocaseiro force-pushed the feature-dashboard-card-buttons branch from df6bb3b to ddd837f Compare January 7, 2022 12:04
jomifepe
jomifepe approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@jomifepe jomifepe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@nunocaseiro nunocaseiro merged commit 42b4fd1 into xgeekshq:main Jan 7, 2022
@nunocaseiro nunocaseiro deleted the feature-dashboard-card-buttons branch February 8, 2022 20:18
nunocaseiro added a commit to nunocaseiro/split that referenced this pull request Feb 11, 2022
@nunocaseiro
feat: share, edit title and delete board from the dashboard (xgeekshq#65
ad89c0c 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jomifepe jomifepe jomifepe approved these changes

Assignees

@nunocaseiro nunocaseiro

Labels
dashboard frontend UI / UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: share, edit title and delete board from dashboard
2 participants
@nunocaseiro @jomifepe