Revert "Add keepAlive message before send file/clipboard data deskflo…

…w#4768" This reverts commit 5287c62.
xioage · Mar 15, 2016 · 7cbd3fd · 7cbd3fd
1 parent b5b2cdf
commit 7cbd3fd
Show file tree

Hide file tree

Showing 7 changed files with 20 additions and 22 deletions.
diff --git a/src/lib/base/EventTypes.cpp b/src/lib/base/EventTypes.cpp
@@ -198,3 +198,4 @@ REGISTER_EVENT(Clipboard, clipboardSending)
 
 REGISTER_EVENT(File, fileChunkSending)
 REGISTER_EVENT(File, fileRecieveCompleted)
+REGISTER_EVENT(File, keepAlive)
diff --git a/src/lib/base/EventTypes.h b/src/lib/base/EventTypes.h
@@ -712,7 +712,8 @@ class FileEvents : public EventTypes {
 public:
 	FileEvents() :
 		m_fileChunkSending(Event::kUnknown),
-		m_fileRecieveCompleted(Event::kUnknown) { }
+		m_fileRecieveCompleted(Event::kUnknown),
+		m_keepAlive(Event::kUnknown) { }
 
 	//! @name accessors
 	//@{
@@ -723,9 +724,13 @@ class FileEvents : public EventTypes {
 	//! Completed receiving a file
 	Event::Type		fileRecieveCompleted();
 
+	//! Send a keep alive
+	Event::Type		keepAlive();
+
 	//@}
 
 private:
 	Event::Type		m_fileChunkSending;
 	Event::Type		m_fileRecieveCompleted;
+	Event::Type		m_keepAlive;
 };
diff --git a/src/lib/client/ServerProxy.cpp b/src/lib/client/ServerProxy.cpp
@@ -252,7 +252,9 @@ ServerProxy::parseMessage(const UInt8* code)
 	}
 
 	else if (memcmp(code, kMsgCKeepAlive, 4) == 0) {
-		keepAlive();
+		// echo keep alives and reset alarm
+		ProtocolUtil::writef(m_stream, kMsgCKeepAlive);
+		resetKeepAliveAlarm();
 	}
 
 	else if (memcmp(code, kMsgCNoop, 4) == 0) {
@@ -890,21 +892,12 @@ ServerProxy::dragInfoReceived()
 void
 ServerProxy::handleClipboardSendingEvent(const Event& event, void*)
 {
-	keepAlive();
 	ClipboardChunk::send(m_stream, event.getData());
 }
 
-void ServerProxy::keepAlive()
-{
-	// echo keep alives and reset alarm
-	ProtocolUtil::writef(m_stream, kMsgCKeepAlive);
-	resetKeepAliveAlarm();
-}
-
 void
 ServerProxy::fileChunkSending(UInt8 mark, char* data, size_t dataSize)
 {
-	keepAlive();
 	FileChunk::send(m_stream, mark, data, dataSize);
 }
 

diff --git a/src/lib/client/ServerProxy.h b/src/lib/client/ServerProxy.h
@@ -107,7 +107,6 @@ class ServerProxy {
 	void				fileChunkReceived();
 	void				dragInfoReceived();
 	void				handleClipboardSendingEvent(const Event&, void*);
-	void				keepAlive();
 
 private:
 	typedef EResult (ServerProxy::*MessageParser)(const UInt8*);

diff --git a/src/lib/server/ClientProxy1_5.cpp b/src/lib/server/ClientProxy1_5.cpp
@@ -35,10 +35,16 @@ ClientProxy1_5::ClientProxy1_5(const String& name, synergy::IStream* stream, Ser
 	ClientProxy1_4(name, stream, server, events),
 	m_events(events)
 {
+
+	m_events->adoptHandler(m_events->forFile().keepAlive(),
+							this,
+							new TMethodEventJob<ClientProxy1_3>(this,
+								&ClientProxy1_3::handleKeepAlive, NULL));
 }
 
 ClientProxy1_5::~ClientProxy1_5()
 {
+	m_events->removeHandler(m_events->forFile().keepAlive(), this);
 }
 
 void
@@ -52,7 +58,6 @@ ClientProxy1_5::sendDragInfo(UInt32 fileCount, const char* info, size_t size)
 void
 ClientProxy1_5::fileChunkSending(UInt8 mark, char* data, size_t dataSize)
 {
-	keepAlive();
 	FileChunk::send(getStream(), mark, data, dataSize);
 }
 

diff --git a/src/lib/server/ClientProxy1_6.cpp b/src/lib/server/ClientProxy1_6.cpp
@@ -50,12 +50,6 @@ ClientProxy1_6::setClipboard(ClipboardID id, const IClipboard* clipboard)
 	if (m_clipboard[id].m_dirty) {
 		// this clipboard is now clean
 		m_clipboard[id].m_dirty = false;
-
-		// add keep alive message before we do clipboard copy
-		// in case there is a big data inside and time that would
-		// comsume will cause connecton being dropped 
-		keepAlive();
-
 		Clipboard::copy(&m_clipboard[id].m_clipboard, clipboard);
 
 		String data = m_clipboard[id].m_clipboard.marshall();
@@ -72,9 +66,6 @@ ClientProxy1_6::setClipboard(ClipboardID id, const IClipboard* clipboard)
 void
 ClientProxy1_6::handleClipboardSendingEvent(const Event& event, void*)
 {
-	// add keep alive message before we send each clipboard data
-	keepAlive();
-
 	ClipboardChunk::send(getStream(), event.getData());
 }
 

diff --git a/src/lib/synergy/StreamChunker.cpp b/src/lib/synergy/StreamChunker.cpp
@@ -84,6 +84,8 @@ StreamChunker::sendFile(
 		}
 
 		if (sendStopwatch.getTime() > SEND_THRESHOLD) {
+			events->addEvent(Event(events->forFile().keepAlive(), eventTarget));
+
 			// make sure we don't read too much from the mock data.
 			if (sentLength + chunkSize > size) {
 				chunkSize = size - sentLength;
@@ -149,6 +151,8 @@ StreamChunker::sendClipboard(
 		}
 
 		if (sendStopwatch.getTime() > SEND_THRESHOLD) {
+			events->addEvent(Event(events->forFile().keepAlive(), eventTarget));
+
 			// make sure we don't read too much from the mock data.
 			if (sentLength + chunkSize > size) {
 				chunkSize = size - sentLength;