Support Swift Package Manager #846
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mtnbarreto |
Climbatize
reviewed
Jul 26, 2023
| let package = Package( | ||
| name: "XLPagerTabStrip", | ||
| platforms: [ | ||
| .iOS(.v9), |
There was a problem hiding this comment.
SPM is only available from XCode 11
|
|
||
| #if SWIFT_PACKAGE | ||
| var bundle = Bundle.module | ||
| #else | ||
| var bundle = Bundle(for: ButtonBarViewCell.self) |
There was a problem hiding this comment.
you can put your #endif here
Suggested change
| var bundle = Bundle(for: ButtonBarViewCell.self) | |
| var bundle = Bundle(for: ButtonBarViewCell.self) | |
| #endif |
| var bundle = Bundle(for: ButtonBarViewCell.self) | ||
| if let resourcePath = bundle.path(forResource: "XLPagerTabStrip", ofType: "bundle") { | ||
| if let resourcesBundle = Bundle(path: resourcePath) { | ||
| bundle = resourcesBundle | ||
| } | ||
| } | ||
|
|
||
| #endif |
|
Sorry, my review was from November 2022, I don't know why it's publishing now 🤣 |
|
Hi @nk-5, thanks for contributing. We have added SPM support in another PR so I will close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
want to use Swift Package Manager
Related issues
Changed
TODO