Add XIP-31: Message History request system #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhaaaa
commented
Jun 28, 2024
jhaaaa
commented
Jun 28, 2024
jhaaaa
commented
Jun 28, 2024
jhaaaa
commented
Jun 28, 2024
Co-authored-by: J-Ha <5481259+jhaaaa@users.noreply.github.com>
rygine
reviewed
Sep 10, 2024
|
|
||
| ### Backup Account Files | ||
|
|
||
| Backup account files are designed as a solution for users who have lost access to all of their XMTP apps. To create a Backup Account File, an app will generate a new set of XMTP keys and register the installation on the XMTP network. The installation contact published to the network will be set with a type of `backup`, which instructs all well-behaved clients to disregard any messages from this installation other than `MessageHistoryBackupResponse`s. This means that a compromised backup installation cannot be used to send messages on the user's behalf, which makes these files a less valuable target for attack. |
There was a problem hiding this comment.
i didn't see any mention of a backup contact in the code. is this something we want to pursue? @neekolas
There was a problem hiding this comment.
It's something we're shelving for now. Nothing is preventing us from adding the backup contact concept later. From the SDK perspective a "backup installation" is just another installation and the history request system would work the same. All the complexity lives at the app level.
rygine
reviewed
Sep 10, 2024
|
|
||
| 5d. Delete the `MessageHistoryBackupResponse` and all associated credentials. | ||
|
|
||
| 5e. Set the status of the `MessageHistoryBackupRequest` to `Applied`. |
There was a problem hiding this comment.
@neekolas we talked about a status field, but i'm not sure it's necessary. is this still something we want to consider?
rygine
reviewed
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.