Identify root cause of issues with staged_commit.group_context() #760
Labels
Comments
neekolas
added a commit
that referenced
this issue
May 21, 2024
## tl;dr - Gets identity working end to end, with tests (pretty much) all uncommented - Updates bindings to have all required methods - Removes a bunch of TODOs in the code ## Follow-ups There are a few changes I had to make to get everything passing that need some follow-up. - xmtp/xmtp-node-go#391 - #760 - #761 - #750 - #762 - #763 There are also many places that need better test coverage.
bwcDvorak
added
Group Chat - Prod
inbox-id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When evaluating commits we need to compare the old and new group context to one another to see the changes in extensions. I would expect
staged_commit.group_context()to return the group context after the extensions proposals have been applied. I could have sworn it used to give us the "after" state. But instead I am seeing it use the before state. We have a mitigation in place, but should investigate why this is happening and if there is a better pattern.The text was updated successfully, but these errors were encountered: