Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group error: Errors occurred during sync [NoChanges] #920

Closed
nplasterer opened this issue Jul 24, 2024 — with Slack · 3 comments
Closed

Group error: Errors occurred during sync [NoChanges] #920

nplasterer opened this issue Jul 24, 2024 — with Slack · 3 comments
Assignees
@insipx
Labels
bug Something isn't working

Comments

@nplasterer Slack
Copy link
Contributor

👋 We're getting an error thrown in converse *LibXMTP.GenericError:* GroupError(message: "Group error: Errors occurred during sync [NoChanges]") (Code: 4)
Am I understanding this error correctly. Is this throwing an error anytime there is no changes detected during a sync?
https://github.com/xmtp/libxmtp/blob/main/xmtp_mls/src/groups/sync.rs#L129-L131

Slack Message
@nplasterer nplasterer added the bug Something isn't working label Jul 24, 2024 — with Slack
@nplasterer
Copy link
Contributor Author

Curious if this is getting thrown here https://github.com/xmtp/libxmtp/blob/main/xmtp_mls/src/groups/sync.rs#L1172-L1175 Going to try and work on a reproduction test. 🙏

@nplasterer
Copy link
Contributor Author

Possibly related to ephemeraHQ/converse-app#365

@insipx insipx self-assigned this Jul 29, 2024
@insipx
Copy link
Contributor

insipx commented Jul 29, 2024 •
edited
Loading

Make NoChanges NoOp #927 should fix this, closing for now

@insipx insipx closed this as completed Jul 29, 2024
This was referenced Jul 29, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@insipx insipx

Labels
bug Something isn't working
Projects
V3 Backlog
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nplasterer @insipx