Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make NoChanges NoOp #927

Merged
merged 7 commits into from
Jul 29, 2024
Merged

Make NoChanges NoOp #927

merged 7 commits into from
Jul 29, 2024

Conversation

insipx
Copy link
Contributor

@insipx insipx commented Jul 29, 2024

This converts the NoChanges err to NoOp in two places. It leaves the error on get_membership_update_intent.

@insipx insipx requested a review from a team as a code owner July 29, 2024 21:34
neekolas
neekolas approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@neekolas neekolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a sensible way of handling these cases without erroring

@insipx insipx merged commit bdeaa75 into main Jul 29, 2024
5 checks passed
@insipx insipx deleted the insipx/no-changes branch July 29, 2024 22:34
@insipx insipx mentioned this pull request Jul 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neekolas neekolas neekolas approved these changes

@nplasterer nplasterer Awaiting requested review from nplasterer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@insipx @neekolas