Provide timestamps in identity action updates #1073
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
There was a problem hiding this comment.
This looks good to me
In case you're wondering why we have both a client_timestamp_ns and a server_timestamp_ns, maybe this is a good time to explain. When you create the IdentityUpdate we include a timestamp included the text that gets signed, so that you can do the same action multiple times and get a unique signature. That lets you associate a wallet, revoke it, and then re-associate the same wallet. If two actions have identical signatures, we will reject the second one.
The server_timestamp_ns only comes once you've uploaded the signed request to our nodes.
codabrink
force-pushed
the
coda/member-timestamp
branch
from
6c90054
to
a7350fa
Compare
codabrink
changed the title
codabrink
force-pushed
the
coda/member-timestamp
branch
from
bf76b0c
to
d98b9ac
Compare
codabrink
force-pushed
the
coda/member-timestamp
branch
from
ebe5645
to
021f463
Compare
codabrink
force-pushed
the
coda/member-timestamp
branch
from
021f463
to
0f3d1b9
Compare
| members.insert(identifier, new_member); | ||
| members | ||
| }, | ||
| members: HashMap::from_iter([(identifier, new_member)]), |
There was a problem hiding this comment.
Heads up @nplasterer this is going to change the group.members() function to be async, which will need to get updated in iOS and Android.
|
#1044 wont be finished until we expose the timestamps for installations in the bindings inbox_state function, but I advise we do that in a follow up PR since changes in here are quite large this one seem ready to merge 🚀 |
Addresses #1044