Update WASM bindings #1122
Merged
Update WASM bindings #1122
+1,555
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
insipx
reviewed
Oct 7, 2024
| encryption_key: Option<Uint8Array>, | ||
| history_sync_url: Option<String>, | ||
| ) -> Result<WasmClient, JsError> { | ||
| xmtp_mls::utils::wasm::init().await; |
There was a problem hiding this comment.
we shouldn't include the tracing setup in prod, instead we should come up with some system similar to the bindings_ffi to pass a logger from javascript/let the client sdk setup logging by calling the init fn themselves. Could be a good followup issue since it's not necessary yet
insipx
approved these changes
Oct 7, 2024
| xmtp_mls = { path = "../xmtp_mls", features = ["message-history"] } | ||
| xmtp_mls = { path = "../xmtp_mls", features = [ | ||
| "message-history", | ||
| "test-utils", |
There was a problem hiding this comment.
should not enable this feature/remove the wasm::init() fn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds more WASM bindings to match our other bindings. Tests and CI workflows to follow.