Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Message Kind #621

Merged
merged 6 commits into from
Apr 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions bindings_ffi/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

40 changes: 35 additions & 5 deletions bindings_ffi/src/mls.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ use xmtp_mls::{
client::Client as MlsClient,
groups::MlsGroup,
storage::{
group_message::StoredGroupMessage, EncryptedMessageStore, EncryptionKey, StorageOption,
group_message::GroupMessageKind, group_message::StoredGroupMessage, EncryptedMessageStore,
EncryptionKey, StorageOption,
},
types::Address,
};
Expand Down Expand Up @@ -224,7 +225,10 @@ impl FfiConversations {
Ok(out)
}

pub fn process_streamed_welcome_message(&self, envelope_bytes: Vec<u8>) -> Result<Arc<FfiGroup>, GenericError> {
pub fn process_streamed_welcome_message(
&self,
envelope_bytes: Vec<u8>,
) -> Result<Arc<FfiGroup>, GenericError> {
let inner = self.inner_client.as_ref();
let group = inner.process_streamed_welcome_message(envelope_bytes)?;

Expand Down Expand Up @@ -365,23 +369,32 @@ impl FfiGroup {
);

let messages: Vec<FfiMessage> = group
.find_messages(None, opts.sent_before_ns, opts.sent_after_ns, None, opts.limit)?
.find_messages(
None,
opts.sent_before_ns,
opts.sent_after_ns,
None,
opts.limit,
)?
.into_iter()
.map(|msg| msg.into())
.collect();

Ok(messages)
}

pub async fn process_streamed_group_message(&self, envelope_bytes: Vec<u8>) -> Result<FfiMessage, GenericError> {
pub async fn process_streamed_group_message(
&self,
envelope_bytes: Vec<u8>,
) -> Result<FfiMessage, GenericError> {
let group = MlsGroup::new(
self.inner_client.as_ref(),
self.group_id.clone(),
self.created_at_ns,
);
let message = group.process_streamed_group_message(envelope_bytes).await?;
let ffi_message = message.into();

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything here and above was from running cargo fmt.

Ok(ffi_message)
}

Expand Down Expand Up @@ -484,13 +497,29 @@ impl FfiGroup {
}
}

#[derive(uniffi::Enum)]
pub enum FfiGroupMessageKind {
Application,
MembershipChange,
}

impl From<GroupMessageKind> for FfiGroupMessageKind {
fn from(kind: GroupMessageKind) -> Self {
match kind {
GroupMessageKind::Application => FfiGroupMessageKind::Application,
GroupMessageKind::MembershipChange => FfiGroupMessageKind::MembershipChange,
}
}
}

#[derive(uniffi::Record)]
pub struct FfiMessage {
pub id: Vec<u8>,
pub sent_at_ns: i64,
pub convo_id: Vec<u8>,
pub addr_from: String,
pub content: Vec<u8>,
pub kind: FfiGroupMessageKind,
}

impl From<StoredGroupMessage> for FfiMessage {
Expand All @@ -501,6 +530,7 @@ impl From<StoredGroupMessage> for FfiMessage {
convo_id: msg.group_id,
addr_from: msg.sender_account_address,
content: msg.decrypted_message_bytes,
kind: msg.kind.into(),
}
}
}
Expand Down
Loading