Test Application ID In Leaf Node #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neekolas
commented
Jan 6, 2024
neekolas
commented
Jan 6, 2024
neekolas
commented
Jan 6, 2024
| .expect("error decoding key package with last resort extension") | ||
| .validate(provider.crypto(), ProtocolVersion::default()) | ||
| .expect("error validating key package with last resort extension"); | ||
| assert!(decoded_kp.extensions().application_id().is_some()); |
neekolas
commented
Jan 6, 2024
| .validate(provider.crypto(), ProtocolVersion::default()) | ||
| .expect("error validating key package with last resort extension"); | ||
| assert!(decoded_kp.extensions().application_id().is_some()); | ||
| assert!(decoded_kp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenMLS spec describes
application_idas something on the leaf nodeAs implemented in OpenMLS,
application_ids set on the key package do not make their way into the extensions of the leaf node. I am not sure if this is an oversight or not. I've added a test case that demonstrates this behaviour, and am happy to make a PR to OpenMLS to allow for this pass-through if we think it's desirable.Or is the idea that one should always put the application ID extension as both a KeyPackage extension and a leaf node extension?