Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Simple Metadata Extension #12

Closed
wants to merge 5 commits into from
Closed

Conversation

keks
Copy link

@keks keks commented Jan 11, 2024

This PR adds the Metadata extension, which contains a simple byte sequence. This is a simplification of ProtectedMetadata, which had provisions to sign the metadata content. In both extensions, interpreting the contents of the byte sequence is up to the application.

This is similar to the ProtectedMetadata extension, with the exception
that the payload is not signed. Whether and how the payload should be
processed is up to the application.
Copy link

@neekolas neekolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be used in addition to ProtectedMetadata? Is the idea here that this would be used for the "mutable metadata" we've been talking about?

@franziskuskiefer
Copy link

Is this meant to be used in addition to ProtectedMetadata? Is the idea here that this would be used for the "mutable metadata" we've been talking about?

Yes. The protected metadata can go away as a struct and instead we use the generic metadata here with a new type and the additional validation check that it can't be changed.
We have the changes ready, but we need to get the upstream changes merged here first before we can do that.
This specific one could be skipped because we'll soon allow unknown extensions. But we'll still need it for the immutable variant, which needs to be processed by openmls.

@keks
Copy link
Author

keks commented Jan 25, 2024

Closing this one, as it is superseded by #17.

@keks keks closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants