Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream main into main #24

Closed
wants to merge 22 commits into from
Closed

Upstream main into main #24

wants to merge 22 commits into from

Conversation

nplasterer
Copy link

This pulls upstream openMLS to get the latest storageAPI work here: openmls#1565.

raphaelrobert and others added 22 commits April 3, 2024 15:21
* Further improve credentials

* Make clippy happy

* Address review comments
* Introduce frankenstein framework

* Remove inaccurate comment

* Add fancy derefs

* More derefs
* Remove cipher suite and version from Secret

* Address review comments
Bumps [peaceiris/actions-gh-pages](https://github.com/peaceiris/actions-gh-pages) from 3 to 4.
- [Release notes](https://github.com/peaceiris/actions-gh-pages/releases)
- [Changelog](https://github.com/peaceiris/actions-gh-pages/blob/main/CHANGELOG.md)
- [Commits](peaceiris/actions-gh-pages@v3...v4)

---
updated-dependencies:
- dependency-name: peaceiris/actions-gh-pages
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [peaceiris/actions-mdbook](https://github.com/peaceiris/actions-mdbook) from 1 to 2.
- [Release notes](https://github.com/peaceiris/actions-mdbook/releases)
- [Changelog](https://github.com/peaceiris/actions-mdbook/blob/main/CHANGELOG.md)
- [Commits](peaceiris/actions-mdbook@v1...v2)

---
updated-dependencies:
- dependency-name: peaceiris/actions-mdbook
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: raphaelrobert <raphaelrobert@users.noreply.github.com>
Due to a recent vcpkg failure (in turn due to a bug in CMake), this PR disables interop testing with MLS++ on CI.

Co-authored-by: raphaelrobert <raphaelrobert@users.noreply.github.com>
This PR allows OpenMLS to handle unknown/other proposals analogous to how extensions are handled.
* Added test for updating unknown group context extensions data

---------

Co-authored-by: cameronvoell <cameronvoell@users.noreply.github.com>
Co-authored-by: Jan Winkelmann (keks) <jan@cryspen.com>
@nplasterer nplasterer self-assigned this Apr 26, 2024
@nplasterer nplasterer marked this pull request as ready for review April 26, 2024 19:35
Copy link

@neekolas neekolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Godspeed to whoever has to handle the upgrade on the xmtp_mls side.

But at least no nasty merge conflicts here

@nplasterer
Copy link
Author

I spoke too soon. I clearly don't know how upstream, forks, and merges work. 😄 #25 But still not tooooo bad of a merge conflict. But definitely some stuff to work through now that the keystore is no longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants