Skip to content
This repository has been archived by the owner on Oct 10, 2024. It is now read-only.

Add Reply content type #11

Merged
merged 8 commits into from
Jul 10, 2023
Merged

Add Reply content type #11

merged 8 commits into from
Jul 10, 2023

Conversation

rygine
Copy link
Collaborator

@rygine rygine commented Jul 5, 2023 •
edited
Loading

Proposal: https://github.com/orgs/xmtp/discussions/35

This PR adds the Reply content type.

@rygine rygine requested a review from jhaaaa as a code owner July 5, 2023 17:45
@rygine rygine requested a review from a team July 5, 2023 17:45
@changeset-bot
Copy link

changeset-bot bot commented Jul 5, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: d13a9d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

jhaaaa
jhaaaa approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@jhaaaa jhaaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the reply content type README, @rygine! Just made a few tech writer edits and added a comment. LGTM!

rygine
rygine commented Jul 6, 2023
View reviewed changes
packages/content-type-reply/src/Reply.ts
reference: content.parameters.reference,
contentType,
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
content: codec.decode(decodedContent as EncodedContent, codecs),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the EncodedContent type from @xmtp/proto might be wrong as we need to assert that this is EncodedContent from @xmtp/xmtp-js. the type key from proto is ContentTypeId | undefined while the same from xmtp-js is just ContentTypeId.

@rygine rygine merged commit 0d300a6 into main Jul 10, 2023
4 checks passed
This was referenced Jul 14, 2023
Closed
Open
Closed
Closed
@rygine rygine deleted the rygine/reply-content-type branch January 16, 2024 20:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nakajima nakajima nakajima left review comments

@jhaaaa jhaaaa jhaaaa approved these changes

@daria-github daria-github daria-github approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rygine @nakajima @jhaaaa @daria-github