Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some logic cleanup #3918

Merged
merged 1 commit into from
Nov 19, 2020
Merged

some logic cleanup #3918

merged 1 commit into from
Nov 19, 2020

Conversation

scopatz
Copy link
Member

@scopatz scopatz commented Oct 21, 2020

No news item needed

@scopatz
Copy link
Member Author

scopatz commented Oct 21, 2020

This is ready for review @xonsh/xore!

daniel-shimon
daniel-shimon reviewed Nov 19, 2020
View reviewed changes
Copy link
Contributor

@daniel-shimon daniel-shimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me! There's no real overhead here, len is just reading from a struct field AFAIK.
If my review is sufficient, let's merge it 😊

@gforsyth gforsyth merged commit 3a34d9f into master Nov 19, 2020
@gforsyth
Copy link
Collaborator

Thanks @scopatz ! And thanks @daniel-shimon for the review and the ping!

@gforsyth gforsyth deleted the logix branch November 19, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-shimon daniel-shimon daniel-shimon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scopatz @gforsyth @anki-code @daniel-shimon