feat: add flake8-bugbear #4288
feat: add flake8-bugbear #4288
Conversation
There was a problem hiding this comment.
These changes look nice, the question is whether we want to introduce yet another linter.
I'm OK with it, @gforsyth what do you think?
| @@ -362,7 +362,7 @@ def format_lazy_import(names): | |||
| def format_from_import(names): | |||
| """Format a from import line""" | |||
| parts = [] | |||
| for _, module, name, asname in names: | |||
| for _, module, name, asname in names: # noqa | |||
There was a problem hiding this comment.
Why not prepend an underscore to the unused vars?
There was a problem hiding this comment.
that module is latter referenced
This contains some important bug detection IMO |
|
I'm not opposed. I think bugbear trips up fewer people because the errors are less common than, say, styling issues. Two asks: |
|
Codecov Report
@@ Coverage Diff @@
## main #4288 +/- ##
========================================
- Coverage 0.92% 0.92% -0.01%
========================================
Files 130 130
Lines 20183 20186 +3
Branches 3638 3638
========================================
Hits 186 186
- Misses 19989 19992 +3
Partials 8 8
Continue to review full report at Codecov.
|
|
Yeah, let's add flake8. Then later we can run precommit itself during the style CI runs and so anyone running precommit locally will be guaranteed to pass on CI |
added qa as whole to pre-commit hook. Added this as pre-push hook since it will take some time to run. |
|
what happened to the news-item checking action? it doesn't seem to be running for recent PRs. |
There was a problem hiding this comment.
Changes here look good to me. @daniel-shimon -- anything else you want to see done here?
As for the news checks, @AstraLuma set them up ages ago and some webhook may not be firing anymore?
We can probably add a news check with github actions fairly easily.
|
I think it's good - thanks @jnoortheen 👌 |
For community
⬇️ Please click the 👍 reaction instead of leaving a
+1or 👍 comment