Include element indexes in undo item when deleting selection

xournalpp · Apr 6, 2024 · 9676776 · 9676776
1 parent bc55e17
commit 9676776
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/src/core/control/tools/EditSelectionContents.cpp b/src/core/control/tools/EditSelectionContents.cpp
@@ -323,13 +323,8 @@ auto EditSelectionContents::setColor(Color color) -> UndoActionPtr {
 void EditSelectionContents::fillUndoItem(DeleteUndoAction* undo) {
     Layer* layer = this->sourceLayer;
 
-    // Always insert the elements on top
-    // Because the elements are already removed
-    // and owned by the selection, therefore the layer
-    // doesn't know the index anymore
-    Element::Index index = as_signed(layer->getElements().size());
-    for (auto& [e, _]: this->insertionOrder) {
-        undo->addElement(layer, std::move(e), index);
+    for (auto& [e, pos]: this->insertionOrder) {
+        undo->addElement(layer, std::move(e), pos);
     }
 
     this->selected.clear();