Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PageTemplateDialog gtk4-compatible #5078

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

bhennion
Copy link
Contributor

@bhennion bhennion commented Aug 21, 2023

This concludes the series of PR's about PageType-related widgetry. Based on #4508

Copy link
Member

@rolandlo rolandlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine according to my tests. I have only some minor nitpicks about the code.

src/core/gui/dialog/PageTemplateDialog.h Show resolved Hide resolved
src/core/gui/dialog/PageTemplateDialog.cpp Outdated Show resolved Hide resolved
src/core/gui/dialog/PageTemplateDialog.cpp Outdated Show resolved Hide resolved
ui/pageTemplate.glade Show resolved Hide resolved
@bhennion
Copy link
Contributor Author

Thanks for the review! Merging in 24 hours.

@bhennion bhennion added the merge proposed Merge was proposed by maintainer label Sep 14, 2023
@bhennion bhennion merged commit f1c1489 into xournalpp:master Sep 15, 2023
5 checks passed
@bhennion bhennion deleted the pr/PageType3 branch September 15, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge proposed Merge was proposed by maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants