Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop failing the run and let the user decide how to proceed #136

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

xt0rted
Copy link
Owner

@xt0rted xt0rted commented Feb 23, 2020

This was brought up in #124. The only time we should fail the run is when the user lacks the required permissions to trigger this step so this removes the calls to setFailed() and replaces them with debug().

To tell if this step was a success or not you can check the out params like so:

- run: echo "Runs only on /lint js command"
  if: steps.command.outputs.command-name && steps.command.outputs.command-arguments == 'js'

A subsequent PR will add a new has-command out parameter that's meant for these types of checks.

This is a breaking change for v1 so it'll be released as v2.

@xt0rted xt0rted added the enhancement New feature or request label Feb 23, 2020
@codecov
Copy link

codecov bot commented Feb 23, 2020

Codecov Report

Merging #136 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #136   +/-   ##
=======================================
  Coverage   86.74%   86.74%           
=======================================
  Files           5        5           
  Lines          83       83           
  Branches       11       11           
=======================================
  Hits           72       72           
  Partials       11       11
Flag Coverage Δ
#unittests 86.74% <100%> (ø) ⬆️
Impacted Files Coverage Δ
src/commandHandler.ts 86.27% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a57d7f...c20683a. Read the comment docs.

@dav009
Copy link

dav009 commented Mar 16, 2020

is this getting merged soon ?

Base automatically changed from master to main March 21, 2021 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants