Merge pull request #226 from james-d-mitchell/fix-compile-warnings

Fix compile warnings
xtensor-stack · Jan 17, 2023 · 6f6ccb0 · 6f6ccb0
2 parents 4d97057 + b2dc1e9
commit 6f6ccb0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/include/xtensor-blas/xlinalg.hpp b/include/xtensor-blas/xlinalg.hpp
@@ -94,9 +94,9 @@ namespace xt
                 {
                     for (std::size_t i = 0; i < v.size(); ++i)
                     {
-                        result += std::abs(std::pow(v(i), ord));
+                        result += static_cast<underlying_value_type>(std::abs(std::pow(v(i), ord)));
                     }
-                    result = std::pow(result, 1. / static_cast<double>(ord));
+                    result = static_cast<underlying_value_type>(std::pow(result, 1. / static_cast<double>(ord)));
                 }
                 return result;
             }

diff --git a/test/test_lapack.cpp b/test/test_lapack.cpp
@@ -178,7 +178,7 @@ namespace xt
             -1.3449222878385465,
             -1.81183493755905478};
 
-        for (int i = 0; i < x_expected.shape()[0]; ++i)
+        for (std::size_t i = 0; i < x_expected.shape()[0]; ++i)
         {
             EXPECT_NEAR(x_expected[i], x[i], 5e-16);
         }
@@ -203,7 +203,7 @@ namespace xt
             -0.05799057434472885,
             0.08606304705465571};
 
-        for (int i = 0; i < x_expected.shape()[0]; ++i)
+        for (std::size_t i = 0; i < x_expected.shape()[0]; ++i)
         {
             EXPECT_DOUBLE_EQ(x_expected[i], x[i]);
         }