Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix npy_file move assignment #2585

Merged
merged 1 commit into from
Jan 10, 2023
Merged

fix npy_file move assignment #2585

merged 1 commit into from
Jan 10, 2023

Conversation

qingyunqu
Copy link
Contributor

@qingyunqu qingyunqu commented Oct 18, 2022 •
edited
Loading

Description

  • fix struct npy_file's Move Assignment.
  • fix memory leak when moving to a npy_file with buffer.

@tdegeus
Copy link
Member

tdegeus commented Jan 9, 2023

Thanks. I'm not an expert on this part of the code. A broad question is what are the CI failures? Could you fix them before we review?

@JohanMabille
Copy link
Member

Thanks for the fix ;)

@JohanMabille JohanMabille merged commit 3158105 into xtensor-stack:master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qingyunqu @tdegeus @JohanMabille