Align qualifiers using clang-format #2647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoinePrv
commented
Jan 27, 2023
| @@ -67,6 +67,8 @@ PenaltyBreakTemplateDeclaration: 0 | |||
| PenaltyExcessCharacter: 10 | |||
| PenaltyIndentedWhitespace: 0 | |||
| PenaltyReturnTypeOnItsOwnLine: 10 | |||
| QualifierAlignment: Custom # Experimental | |||
| QualifierOrder: [inline, static, constexpr, const, volatile, type] | |||
There was a problem hiding this comment.
@JohanMabille @tdegeus here is the setting for the ordering.
I'm happy to change it to east-const if you'd like ;)
There was a problem hiding this comment.
Very nice, makes the code significantly more readable!
tdegeus
approved these changes
Jan 27, 2023
|
Is |
|
It is Yaml indeed. Perhaps we can the file explicitly to the yaml pre-commit hooks. |
|
That would be great indeed! |
|
This seems to do the trick, but it seems to not be a hook for sorting yaml (which is probably better, sorting is not always a good fit for configs). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This option is experimental, let's see if it works.