move venv creation to Docker rather than postCreateCommand script

xuwenhao · Dec 31, 2023 · 6825e05 · 6825e05
1 parent 6873ff9
commit 6825e05
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile
@@ -17,6 +17,10 @@ USER $USERNAME
 
 RUN cd ~ && wget https://raw.githubusercontent.com/ohmyzsh/ohmyzsh/master/tools/install.sh && sh install.sh
 
+# Create and activate a Python virtual environment
+RUN python -m venv ~/venv
+RUN echo "source ~/venv/bin/activate" >> ~/.zshrc
+
 RUN echo "export PYTHONPATH=\$PYTHONPATH:/workspace" >> ~/.zshrc
 RUN /bin/zsh ~/.zshrc
 

diff --git a/.devcontainer/postCreateCommand.sh b/.devcontainer/postCreateCommand.sh
@@ -1,6 +1,4 @@
 #!/bin/bash
-python -m venv ~/venv
-echo "source ~/venv/bin/activate" >> ~/.zshrc
 source /home/vscode/venv/bin/activate
 pip config set global.index-url https://pypi.tuna.tsinghua.edu.cn/simple
 pip install -r requirements.txt