Add state resetting at the end of the request #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dnna Got some docs about that |
|
I don't think its well documented but you can read about it in symfony/symfony#23984 and symfony/symfony#24155 :) |
|
Looks good to me :-) |
stefandoorn
approved these changes
Aug 29, 2018
|
I will give you asap feedback, merge it and create a new release ;) |
|
Looks also good to me, thank you for your contribution @dnna and @stefandoorn for your review 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this plugin with https://github.com/php-pm/php-pm the events are added multiple times because they are saved internally and carried over to the next request. This PR fixes this by using Symfony's kernel.reset tag that is designed for this purpose.