-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clp-s: Add support for using "?" in wildcard queries on single-word values (resolves #392). #409
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
58909ce
fix wildcard issues
wraymo 539920a
apply suggestions from code review
wraymo bbc7b96
minor touch
wraymo 799f93d
escape character for exact match
wraymo 187967a
lint fix
wraymo 6a90b55
add has_unescaped_wildcards() method
wraymo d1e0eef
remove cautions
wraymo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
escape character for exact match
- Loading branch information
commit 799f93de6bbe63d31d8ab5e15f906f36edf92de1
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to my other comment we should be handling escaping here as well. Specifically if there are no unescaped
*
or?
we should enter this code block, process the string to unescape escaped characters as necessary, then do the precise search.E.g.
\\var\?
should enter this code block and get unescaped to become\var?
before performing exact match.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the function
wildcard_match_unsafe_case_sensitive
can handle escape characters correctly. The corner case was mentioned above and will be fixed later.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, but this code block uses
m_var_dict->get_entry_matching_value()
which doesn't respect escape characters.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe for the condition here we can add a method like
and replace the if condition with
false == has_unescaped_wildcards(query)
?