relationship terminal state test

elide-core/src/test/java/com/yahoo/elide/core/LifeCycleTest.java

@@ -50,6 +50,7 @@
 import com.yahoo.elide.security.checks.Check;
 
 import com.google.common.collect.ImmutableList;
+import com.google.common.collect.ImmutableSet;
 import com.google.common.collect.Sets;
 
 import example.Author;
@@ -252,6 +253,40 @@ public void testElideGet() throws Exception {
         verify(tx).close();
     }
 
+    @Test
+    public void testElideGetRelationship() throws Exception {
+        DataStore store = mock(DataStore.class);
+        DataStoreTransaction tx = mock(DataStoreTransaction.class);
+        Book book = mock(Book.class);
+        Author author = mock(Author.class);
+        when(book.getId()).thenReturn(1L);
+        when(author.getId()).thenReturn(2L);
+        when(book.getAuthors()).thenReturn(ImmutableSet.of(author));
+
+        Elide elide = getElide(store, dictionary, MOCK_AUDIT_LOGGER);
+
+        when(store.beginReadTransaction()).thenCallRealMethod();
+        when(store.beginTransaction()).thenReturn(tx);
+        when(tx.loadObject(eq(Book.class), any(), any(), isA(RequestScope.class))).thenReturn(book);
+
+        MultivaluedMap<String, String> headers = new MultivaluedHashMap<>();
+        ElideResponse response = elide.get("/book/1/relationships/authors", headers, null);
+        assertEquals(HttpStatus.SC_OK, response.getResponseCode());
+
+        /*
+         * This gets called for :
+         *  - read pre-security for the book
+         *  - read pre-commit for the book
+         *  - read post-commit for the book
+         */
+        verify(callback, times(3)).execute(eq(book), isA(RequestScope.class), any());
+        verify(tx).accessUser(any());
+        verify(tx).preCommit();
+        verify(tx).flush(any());
+        verify(tx).commit(any());
+        verify(tx).close();
+    }
+
     @Test
     public void testElidePatch() throws Exception {
         DataStore store = mock(DataStore.class);

elide-core/src/test/java/com/yahoo/elide/core/PersistentResourceTest.java

@@ -50,6 +50,8 @@
 import com.yahoo.elide.security.User;
 import com.yahoo.elide.security.checks.OperationCheck;
 
+import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.ImmutableSet;
 import com.google.common.collect.Lists;
 import com.google.common.collect.Sets;
 import example.Author;
@@ -115,6 +117,7 @@ public PersistentResourceTest() {
         badUserScope = new RequestScope(null, null, mock(DataStoreTransaction.class),
                 new User(-1), null, elideSettings);
         reset(goodUserScope.getTransaction());
+        assertFalse(goodUserScope.isUseFilterExpressions());
     }
 
     @Test
@@ -1665,6 +1668,7 @@ public void testCreateObjectSuccess() {
         assertEquals(parent, created.getObject(),
                 "The create function should return the requested parent object"
         );
+        assertTrue(goodScope.isNewResource(parent));
     }
 
     @Test()
@@ -2199,6 +2203,7 @@ public void testFilterExpressionByType() {
 
         RequestScope scope = new RequestScope("/", null, mock(DataStoreTransaction.class),
                 new User(1), queryParams, elideSettings);
+
         Optional<FilterExpression> filter = scope.getLoadFilterExpression(Author.class);
         FilterPredicate predicate = (FilterPredicate) filter.get();
         assertEquals("name", predicate.getField());
@@ -2208,6 +2213,20 @@ public void testFilterExpressionByType() {
         assertEquals("[Author].name", predicate.getPath().toString());
     }
 
+    @Test
+    public void testSparseFields() {
+        MultivaluedMap<String, String> queryParams = new MultivaluedHashMap<>();
+
+        queryParams.add("fields[author]", "name");
+
+        RequestScope scope = new RequestScope("/", null, mock(DataStoreTransaction.class),
+                new User(1), queryParams, elideSettings);
+        Map<String, Set<String>> expected = ImmutableMap.of("author", ImmutableSet.of("name"));
+        System.err.println(scope.getPagination());
+        assertEquals(10, scope.getPagination().getLimit());
+        assertEquals(0, scope.getPagination().getPageTotals());
+    }
+
     @Test
     public void testEqualsAndHashcode() {
         Child childWithId = newChild(1);